Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: allow sending metadata with CreateDir and Upload requests #7

Open
1 of 4 tasks
butonic opened this issue Mar 19, 2019 · 4 comments
Open
1 of 4 tasks

Comments

@butonic
Copy link
Contributor

butonic commented Mar 19, 2019

We should allow sending MD Metadata with

  • FS.CreateDir and
  • FS.Upload to send along the original ctime and mtime as well as extended attributes.

Furthermore, we need to be able to manipulate metadata, in order to

  • implement touch()
  • set extended attributes
@moscicki
Copy link
Contributor

@butonic: correct. we are cleaning all these things up properly on the review branch.

@labkode
Copy link
Member

labkode commented Mar 19, 2019

@butonic the opaque field helps in this case, for example here:
https://github.com/cernbox/cs3apis/blob/review/cs3/storageprovider/v0alpha/storageprovider.proto#L157

If we know that there will be logic used by many implementations then those use-cases can be promoted to non-opaque fields.

@moscicki
Copy link
Contributor

We should add attributes to ExtraMetadata wherever it makes sense and does not depend on particular storage backend:

https://github.com/cernbox/cs3apis/blob/review/cs3/storageprovider/v0alpha/resources.proto#L138

I would avoid creating too many hidden stuff in Opaque because it will be breaking the "standard".

@labkode
Copy link
Member

labkode commented Mar 19, 2019

We should add attributes to ExtraMetadata wherever it makes sense and does not depend on particular storage backend:

https://github.com/cernbox/cs3apis/blob/review/cs3/storageprovider/v0alpha/resources.proto#L138

I would avoid creating too many hidden stuff in Opaque because it will be breaking the "standard".

If many storage back ends support it

@butonic butonic changed the title allow setting metadata storage: allow setting metadata Mar 20, 2019
@butonic butonic changed the title storage: allow setting metadata storage: allow sending metadata with CreateDir and Upload requests Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants