Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checks/cs50/2019/x/finance/check50/lookup.py (Handle lower case symbol) #75

Open
napitts opened this issue May 27, 2019 · 0 comments
Open

checks/cs50/2019/x/finance/check50/lookup.py (Handle lower case symbol) #75

napitts opened this issue May 27, 2019 · 0 comments

Comments

@napitts
Copy link

napitts commented May 27, 2019

lookup.py

  • IEX API will accept lower case symbols.
  • Student may choose to convert form input to lower case for consitency, prior to calling lookup() or storing in the database
  • This creates an issue when using check50, but not when using regular IEX API

Recommend to change lookup.py to better mimic IEX API, such as:
if (symbol.upper() == "AAAA"):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@napitts