Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waitForClick bug #18

Closed
dmalan opened this issue Jan 25, 2017 · 2 comments
Closed

waitForClick bug #18

dmalan opened this issue Jan 25, 2017 · 2 comments
Assignees
@cmlsharp

Comments

@dmalan
Copy link
Member

dmalan commented Jan 25, 2017 •
edited
Loading

---------- Forwarded message ----------

Looks like this is indeed a bug in SPL.

With GDB I can see that waitForClick() is always reached, but if the mouse was moving at the time waitForClick gets called, a click is processed even with no click.

---------- Forwarded message ----------

After I noticed a bug in a student's program where if they moved the mouse as the ball was hitting the bottom edge, the game wouldn't wait for a click (event though he requested it to) and the ball would reset its location and keep moving (the amount of lives was still correct).

I tried this using the staff's implementation, and the bug was there was well.
@dmalan
Copy link
Member Author

dmalan commented Jun 1, 2017

@crossroads1112 mind trying to reproduce?

@cmlsharp
Copy link

cmlsharp commented Jun 1, 2017

This seems to have been fixed in the port

@dmalan dmalan closed this as completed Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmlsharp cmlsharp

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmalan @cmlsharp