Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube upload #19

Closed
12345ieee opened this issue Aug 26, 2018 · 2 comments
Closed

Youtube upload #19

12345ieee opened this issue Aug 26, 2018 · 2 comments
Assignees
Labels
wish Someone would like to see this as a patch. We may or may not implement it, but it sounds doable.

Comments

@12345ieee
Copy link
Collaborator

The YT upload uses an old API that doesn't work anymore.

Either disallow the user from trying an upload (gray out or remove the button) or get it to work again.

@12345ieee 12345ieee added the wish Someone would like to see this as a patch. We may or may not implement it, but it sounds doable. label Aug 26, 2018
@csaboka
Copy link
Owner

csaboka commented Sep 16, 2018

Looks like fixing YT upload would be a real pain. The current API only supports OAuth2 authentication, which in turn requires someone to create authorization credentials in their Google account. Those credentials then need to be kept secret to make sure no one can impersonate your client (SpaceChem in our case) and make changes on its behalf.

Keeping secrets in an open source project isn't really possible. The closest we could get is a closed-source webservice running somewhere online, which takes requests from SpaceChem and sends them to YouTube with the right authentication. It's just not worth it for a hobby project.

Removing the button, on the other hand, should be easy now that we mostly understand how the GUI works.

@csaboka csaboka self-assigned this Sep 16, 2018
@csaboka
Copy link
Owner

csaboka commented Sep 16, 2018

I've just pushed a patch that allows removing YT upload functionality altogether. Videos are automatically saved to the desktop instead, since that's the only remaining option.

Note that the solution recording button still says that you can upload the video to YT. Changing this text would mean we're introducing new text to the game. We would either have to translate that new text to each supported language, or have it show up in English for everyone. I'd rather not open that can of worms now.

@csaboka csaboka closed this as completed Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wish Someone would like to see this as a patch. We may or may not implement it, but it sounds doable.
Projects
None yet
Development

No branches or pull requests

2 participants