Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GH Action checks #507

Closed
tschmidtb51 opened this issue Nov 15, 2023 · 1 comment · Fixed by #510
Closed

Improve GH Action checks #507

tschmidtb51 opened this issue Nov 15, 2023 · 1 comment · Fixed by #510
Assignees
Labels
question Further information is requested service+dev

Comments

@tschmidtb51
Copy link
Collaborator

Currently, we run the go.yml just on pushs.

@s-l-teichmann Wouldn't it be useful to automatically run it on pull requests as well or was that a specific choice? If we run it on Pull Requests as well, it would make it easier for reviewers to find the obvious mistakes...

I'm happy to implement the change - I just can't remember whether this was an active decision (and if so what the reasons were).

@tschmidtb51 tschmidtb51 added the question Further information is requested label Nov 15, 2023
@tschmidtb51 tschmidtb51 self-assigned this Nov 15, 2023
@s-l-teichmann
Copy link
Collaborator

@tschmidtb51 Yes, we should do that and there were no active decisions not doing this.
I think this a historical artifact. The amount of external PRs were small and our internal
pushes are triggering the actions.

@tschmidtb51 tschmidtb51 linked a pull request Nov 16, 2023 that will close this issue
@bernhardreiter bernhardreiter added this to the Release 3.0.0-rc.2 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested service+dev
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants