Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pytorch core code-base from nvfuser repo #2388

Closed
jjsjann123 opened this issue Jan 30, 2023 · 5 comments
Closed

remove pytorch core code-base from nvfuser repo #2388

jjsjann123 opened this issue Jan 30, 2023 · 5 comments
Assignees

Comments

@jjsjann123
Copy link
Collaborator

馃殌 The feature, motivation and pitch

We'll do a git filter-repo on nvfuser folder and strip pytorch core code-base from nvfuser.

I tried it with current nvfuser devel branch + a pytorch master repo from upstream. Currently there's some expected failures:

  1. dynamo + primTorch: Since we updated our python APIs, and will continue to do so. Related changes needs to be pushed to upstream. But we will need to figure out how we would want to do that. I think the easier way is that we do the filter-repo first on our branch (basically ignoring those failures) and once we have that, we'll be able to convert upstream pytorch third_party/nvfuser into using a submodule instead of real code there. Need to follow this up with upstream folks.

  2. TorchScript test in test_jit_cuda_fuser.py. There were some tests related to gather and index_select that are failing. For gather, I know it's coming from our changes in symbolic_scripts, which is not pushed to upstream. We'll need to do that. Not any clue on why index_select is failing though. Would need some investigation.

Alternatives

No response

Additional context

No response

@jjsjann123 jjsjann123 self-assigned this Jan 30, 2023
@jjsjann123
Copy link
Collaborator Author

pushing autodiff changes to upstream: pytorch#93333

@jjsjann123
Copy link
Collaborator Author

patching the squeeze issue: #2404

@jjsjann123
Copy link
Collaborator Author

Patching upstream nvfuser python frontend changes: pytorch#94036

@jjsjann123
Copy link
Collaborator Author

One remaining issue is the view -> reshape renaming. Need to patch that then we are good to go with merging jit/nightly container.

cc'ing @xwang233. I believe with the patch pytorch#94036, we should no longer require stacked commit on top nv pytorch. 馃檹

@jjsjann123
Copy link
Collaborator Author

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant