Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #1

Open
aGuttman opened this issue Nov 28, 2017 · 3 comments
Open

Feedback #1

aGuttman opened this issue Nov 28, 2017 · 3 comments

Comments

@aGuttman
Copy link

Seems a little small. Think about ways you might want to expand the project. Also, your proposal doesn't make it clear if you already basically know how to do variadic functions or not. If you do, this is definitely too small, and even if it something you still have to learn it's not really up to par.

@Anonymous-Stranger
Copy link
Contributor

Are variadics particularly trivial to implement? We decided to add them because they are an actually useful language feature, rather than some novel yet foolish modification that could mar the beauty of Python. Moreover, we're already having enough trouble compiling plain functions (we still can't), so for our skill level, variadics is a big step.

Can you recommend a better project you feel we can complete by the deadline?

@Anonymous-Stranger
Copy link
Contributor

@aGuttman

@aGuttman
Copy link
Author

I wouldn't call it trivial exactly, but it is pretty straightforward. In your schedule, you give yourselves two weeks to implement this feature, which is the amount of time a homework typically gets, and it is definitely a smaller problem than the homeworks.

It's unfortunate that you you don't have functions working yet; that requires you to do extra work before you can even start working on the project, so I can understand why you would be hesitant to take on more. I don't think it is a bad feature to implement, but I wouldn't expect an excellent grade even if you do it perfectly (though I am not involved in the grading process at all).

If you have a more concrete and detailed proposal, we might be able to give better feedback about appropriate scope. Most other groups have proposals 2+ pages long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants