Skip to content
This repository has been archived by the owner on Feb 25, 2022. It is now read-only.

pushing routes with queryParams #89

Closed
csells opened this issue Oct 13, 2021 Discussed in #88 · 5 comments
Closed

pushing routes with queryParams #89

csells opened this issue Oct 13, 2021 Discussed in #88 · 5 comments
Labels
bug Something isn't working fix awaiting confirmation

Comments

@csells
Copy link
Owner

csells commented Oct 13, 2021

params, queryParams and the extra param are all supported for push but not all are working at the moment. I'll fix asap.

Discussed in #88

Originally posted by raulmabe October 12, 2021
I am trying to push a route (/search) with queryParams from a top-level route (/) but throws AssertionError because of the following constraint assert(identical(match.queryParams, matches.first.queryParams)); in line 661.

Is it incompatible to use push and queryParams at the same time? Same happens with the extra property

@csells csells added the bug Something isn't working label Oct 13, 2021
@csells
Copy link
Owner Author

csells commented Oct 17, 2021

fixed in v2.1.2. @raulmabe can you please verify?

@elias8
Copy link

elias8 commented Oct 18, 2021

Hi @csells 👋,

I am currently having an issue navigating to a route with a param, where the param could contain a space when navigating. So does this address that issue, or should I submit a new one?

@csells
Copy link
Owner Author

csells commented Oct 18, 2021

That sounds like a new one

@raulmabe
Copy link

fixed in v2.1.2. @raulmabe can you please verify?

I can verify I no longer encounter this issue. Thank you 🙌🏼

@csells csells closed this as completed Oct 19, 2021
@elias8
Copy link

elias8 commented Oct 19, 2021

I am currently having an issue navigating to a route with a param, where the param could contain a space when navigating. So does this address that issue, or should I submit a new one?

That sounds like a new one

I was using params instead of queryParams which doesn't allow empty spaces 😅. Also, I had the original issue submitted by @raulmabe, which I can also confirm fixed in v2.1.2.

Thanks! 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fix awaiting confirmation
Projects
None yet
Development

No branches or pull requests

3 participants