-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
header auth matching breaks with Werkzeug>=2.3.0 #241
Comments
17 tasks
Hi there, Thanks for the fine bug report! Zsolt |
I'll implement |
thanks @davidism! @alexrashed, are you ok with having this fix in the next release of werkzeug? |
2.3.1 has been released, the tests pass, so I'm closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With Werkzeug 2.3.0 the Authorization header parsing has been refactored quite a lot: pallets/werkzeug@0bdf9ba.
Here's an excerpt from the changeset:
Unfortunately, this means that this class does not implement the
__eq__
dunder method, which breaks this equality check:pytest-httpserver/pytest_httpserver/httpserver.py
Lines 135 to 136 in 1df798a
Here's an example which works with
pytest-httpserver==1.0.6
andWerkzeug==2.2.3
, but breaks withWerkzeug==2.3.0
:This could either be fixed by adjusting the matcher, or by adding the
__eq__
dunder method to Werkzeug'sAuthorization
class (which might be useful for others as well?).The text was updated successfully, but these errors were encountered: