QT doesn't need svg #195
QT doesn't need svg #195
Conversation
It looks like QT doesn't need svg here. This causes the binary to attempt linking to qtsvg, however, since gqrx doesn't actually use qtsvg, this seems kinda silly. the downstream bug is here: https://bugs.gentoo.org/show_bug.cgi?id=521206 Are we missing something?
|
Are you sure we don't need that? All the icons are in SVG format so at some point the SVG API is needed. I can't see the bug at the moment but will check it later. |
|
I am 100% certain that it doesn't need to be linked to qtsvg, as the linking actually is a no-op and the final binary is not linked to qtsvg when you use --as-needed (gentoo default). This patch prevents qtsvg from being on the linker line for no reason at all. QTsvg is actually needed as a runtime dep as far as I can tell, which means it needs to be installed to run gqrx, but not to build. |
|
Ok, thanks for the clarification. |
|
I didn't include it in my PR, but you may wish to add a note that QTsvg is needed at runtime? |
|
Most distros split up QT quite a bit, in gentoo for instance we have qtgui and qtcore as build deps, and qtsvg as a runtime dep. I can amend the README.md at your request, or you can handle it as you see fit. |
|
Yeah, most distributions have separate packages for the different components, then both Qt 4 and 5 :) |
It looks like QT doesn't need svg here. This causes the binary to attempt linking to qtsvg, however, since gqrx doesn't actually link to qtsvg, this seems kinda silly.
the downstream bug is here:
https://bugs.gentoo.org/show_bug.cgi?id=521206
This PR removes the build time dep (since it isn't used at build time). QTsvg should be a runtime dep only.