Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crop params in percent size #26

Closed
pletessier opened this issue Feb 11, 2022 · 2 comments
Closed

Crop params in percent size #26

pletessier opened this issue Feb 11, 2022 · 2 comments

Comments

@pletessier
Copy link
Contributor

Hi,
Thanks for this tool. It looks amazing !

My use case is to crop images by giving left-top and right-bottom coords as percent of width and height of the image.
So the params would be float values between 0 and 1, such as "0.10x0.08:0.26x0.43".

Of course, I don't have image width and height infos on the client side, otherwise it would have been easy to compute pixels-coords automatically.

Is there any way to achieve this with the current version of Imagor ? If not, would you be open to a PR ?
@cshum
Copy link
Owner

cshum commented Feb 11, 2022

Imagor currently does not support crop by percentage. PR is welcomed :)

@pletessier pletessier mentioned this issue Feb 14, 2022
Merged
@cshum
Copy link
Owner

cshum commented Feb 16, 2022

Crop params in percentage is now available in docker image shumc/imagor:0.8.11!

@cshum cshum closed this as completed Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cshum @pletessier