Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative Source #7

Closed
IzzySoft opened this issue Feb 2, 2019 · 7 comments
Closed

Alternative Source #7

IzzySoft opened this issue Feb 2, 2019 · 7 comments

Comments

@IzzySoft
Copy link

IzzySoft commented Feb 2, 2019

I see you already attach APKs to your releases, which is great – but unfortunately they are only debug builds. Would you mind using release builds instead? Or even have your app listed at F-Droid?

@csicar
Copy link
Owner

csicar commented Feb 3, 2019

I have created a release apk. Can be found here

F-Droid integration is definitely the long-term goal; I've stared working on integration in F-Droid here, but I haven't created a merge-request yet.

@IzzySoft
Copy link
Author

IzzySoft commented Feb 3, 2019

Thanks! Unfortunately apksigner is of the opinion the APK is not (correctly) signed:

$ apksigner verify app-release.apk
DOES NOT VERIFY
ERROR: No JAR signatures

If you could fix that, I'd offer you to serve your app in my repo until you feel ready for the official one (being one of the F-Droid maintainers, I gladly help you with the RFP as well).

@csicar
Copy link
Owner

csicar commented Feb 4, 2019

The release is updated with JAR signatures.

I'd offer you to serve your app in my repo

Sure, Go for it!

@IzzySoft
Copy link
Author

IzzySoft commented Feb 4, 2019

Thanks, added! Should show up here with the next sync (probably tomorrow 8pm). Hope you like the description then: your repo had none, so I needed to make one up 😄

From what my scanner said, your app should be eligible for the official repo. So just let me know if you want it listed there.

@csicar
Copy link
Owner

csicar commented Feb 5, 2019

I like the description; seems quite fitting.

So just let me know if you want it listed there.

Yes, for sure!

@IzzySoft
Copy link
Author

IzzySoft commented Feb 5, 2019

Thanks! Here you go. Tonight the bot should check your repo and give a thumbs up (at least I hope so) – and then I'll mark it ready-to-build. Once it got picked up and merged, it should show up in the catalogue within a few days – which is when I'll remove it from my repo again (to avoid confusion, as the signatures won't match).

@IzzySoft
Copy link
Author

IzzySoft commented Feb 5, 2019

PS: our bot found a security issue with your gradle you might wish to fix. Doesn't affect F-Droid, but your own builds.

@csicar csicar closed this as completed Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants