Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can generate output that can crash midiviz #1

Closed
csillag opened this issue Jun 1, 2020 · 2 comments
Closed

Can generate output that can crash midiviz #1

csillag opened this issue Jun 1, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@csillag
Copy link
Owner

csillag commented Jun 1, 2020

For some MIDI file inputs we get an output which crashes the MIDIVisualizer fork.

It's not entirely obvious what is wrong with the MIDI file (if anything), because the upstream version of MIDIVisualizer can parse the generated output without any problem.

See the sample.

sample.zip

@csillag csillag added the bug Something isn't working label Jun 1, 2020
@csillag
Copy link
Owner Author

csillag commented Jun 1, 2020

Apparently, just adding a new track to this input MID file is sufficient to make midiviz crash.

@csillag
Copy link
Owner Author

csillag commented Jun 1, 2020

Apparently, it's the type of the MIDI file that is set wrong.

    // MIDI 0: All information in 1 track
    // MIDI 1: Multiple tracks intended to be played simultaneously
    // MIDI 2: Multiple tracks intended to be played separately

When adding a new track, we are supposed to set it from 0 to 1.

@csillag csillag closed this as completed in 7a7f72c Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant