Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netcoreapp3.0 target is not supported since March 3, 2020 #21

Closed
FyiurAmron opened this issue Nov 22, 2020 · 2 comments
Closed

netcoreapp3.0 target is not supported since March 3, 2020 #21

FyiurAmron opened this issue Nov 22, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@FyiurAmron
Copy link

FyiurAmron commented Nov 22, 2020

See https://dotnet.microsoft.com/platform/support/policy/dotnet-core for details. Migration to at least Core 3.1 (LTS, but actual support time is roughly the same as of .NET 5) or .NET 5 preferably (both would be supported until at least 2022) would solve this completely (currently, targetting 3.0 results in a spam of NETSDK1138 warnings).

Official doc: https://docs.microsoft.com/en-us/aspnet/core/migration/31-to-50 (also https://docs.microsoft.com/en-us/aspnet/core/migration/30-to-31 to a lesser extent)

Checking this by fixing the csprojs by hand didn't result in any obvious issues. I can create a PR with these changes if it's the preferred way to handle this, no biggie.

As a side note: if compatibility with Mono/Xamarin is not an issue, using net5.0 profile consistently instead of e.g. netstandard2.1 etc. would be more futureproof.

@csinkers
Copy link
Owner

Ah yup, been meaning to do that. I think I'd left it on 3.0 due to a compiler bug that was introduced in one of the 3.1 releases, that's been resolved now so no reason not to. I'm currently in the middle of a massive refactor of the asset system, but I'll bump the .NET Core version as part of that. Would like to move to 5 at some point as well to take advantage of the new code generation stuff etc, but will need to do some testing first.

@csinkers
Copy link
Owner

Ok, the branch has been merged in with the .NET version update now so closing the issue. Will move to .NET 5 once I've got some time.

@csinkers csinkers added the enhancement New feature or request label Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants