Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent types for RuleFit._extract_rules() #173

Closed
marcjulianschwarz opened this issue May 28, 2023 · 1 comment
Closed

Inconsistent types for RuleFit._extract_rules() #173

marcjulianschwarz opened this issue May 28, 2023 · 1 comment

Comments

@marcjulianschwarz
Copy link

The method _extract_rules() in the class RuleFit has List[Rule] as type annotation for the return value.
However it returns the result of extract_rulefit() which returns a list of strings.
@csinva
Copy link
Owner

csinva commented May 28, 2023

Thanks for catching this! Just fixed in 04ecbd8

@csinva csinva closed this as completed May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@csinva @marcjulianschwarz