Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complexity comparisons #31

Merged
merged 6 commits into from Feb 22, 2021
Merged

Complexity comparisons #31

merged 6 commits into from Feb 22, 2021

Conversation

keyan3
Copy link
Collaborator

@keyan3 keyan3 commented Feb 22, 2021

  • Compare all models on several UCI datasets
  • Generate complexity-accuracy plots for each model
  • Cache comparison results for convenience
  • Set self.complexity when fitting models

@csinva
Copy link
Owner

csinva commented Feb 22, 2021

This is awesome!

Now that there's a bunch of them, can you move the .pkl files to tests/test_data so they don't get dragged around with the package? (my fault for setting this up poorly initially).

@keyan3
Copy link
Collaborator Author

keyan3 commented Feb 22, 2021

This is awesome!

Now that there's a bunch of them, can you move the .pkl files to tests/test_data so they don't get dragged around with the package? (my fault for setting this up poorly initially).

sounds good!

@csinva
Copy link
Owner

csinva commented Feb 22, 2021

Perfect!

@csinva csinva merged commit 8f0d7d9 into master Feb 22, 2021
@csinva csinva deleted the complexity-comparisons branch February 22, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants