Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OWM25._encode_string returns nothing if passed a unicode string #143

Closed
alechewitt opened this issue Nov 2, 2016 · 1 comment
Closed

OWM25._encode_string returns nothing if passed a unicode string #143

alechewitt opened this issue Nov 2, 2016 · 1 comment
Milestone
Release 2.6.0

Comments

@alechewitt
Copy link
Contributor

alechewitt commented Nov 2, 2016 •
edited by csparpa
Loading

The static method OWM25._encode_string will return None if passed a unicode string. Eg:

test = u'teststring'
encoded_str = OWM25._encode_string(test)

encoded_str now equals None
@csparpa csparpa added this to the Release 2.6.0 milestone Nov 2, 2016
@csparpa
Copy link
Owner

csparpa commented Nov 3, 2016

Fixed with 1332b83

I forgot to put a return and the test case could not catch it as it is a corner-case which cannot be tested with Python 3.x

@csparpa csparpa closed this as completed Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.6.0
Development

No branches or pull requests
2 participants
@alechewitt @csparpa