Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking interface change wrongly released with 2.5 #158

Closed
csparpa opened this issue Dec 14, 2016 · 1 comment
Closed

Breaking interface change wrongly released with 2.5 #158

csparpa opened this issue Dec 14, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@csparpa
Copy link
Owner

csparpa commented Dec 14, 2016

I wrongly released a breaking change with 2.5, apologies for that!

Function webapi25.owm25.get_version used to return a string, I changed it so that it returned a tuple
Eg:

owm.get_version()  # used to return: "2.5.0" but now returns (2, 5, 0)

Returning a string should be restored and a deprecation should be introduced for that function and webapi25.owm25.get_API_version as well explaining that the return type will be modified on version 3.0.0 onwards

@csparpa
Copy link
Owner Author

csparpa commented Dec 16, 2016

Done with #161

@csparpa csparpa closed this as completed Dec 16, 2016
@csparpa csparpa removed this from Done in PyOWM Versions Roadmap May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant