Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate JsonContainerDefinitionSerializer #227

Closed
cspray opened this issue Aug 16, 2022 · 0 comments
Closed

Deprecate JsonContainerDefinitionSerializer #227

cspray opened this issue Aug 16, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@cspray
Copy link
Owner

cspray commented Aug 16, 2022

The existing JSON serialization has various issues with the format and needs to be updated to include support for serializing Inject values correctly. In addition, a new XML serializer format is being implemented that can replace the JSON format for caching purposes and is meant to be suitable for uses in static analysis contexts.

It doesn't really make sense for us to provide multiple serialization formats. Serializing a ContainerDefinition is complicated and having multiple implementations is most likely going to lead to pain. Because the XML serializer solves problems that exists in the JSON serializer and will provide other functionality it does not make sense to offer both.

@cspray cspray added the enhancement New feature or request label Aug 16, 2022
@cspray cspray added this to the v1.6 Release milestone Aug 16, 2022
@cspray cspray self-assigned this Aug 16, 2022
@cspray cspray closed this as completed Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant