Skip to content
This repository has been archived by the owner on Oct 22, 2023. It is now read-only.

Further bug patches #25

Merged
merged 5 commits into from
May 17, 2022
Merged

Further bug patches #25

merged 5 commits into from
May 17, 2022

Conversation

cxmeel
Copy link
Owner

@cxmeel cxmeel commented May 17, 2022

Summary of PR:

  • Add global ignores to .GetIgnoredPropertyNames: Globally ignored properties are now included in the .GetIgnoredPropertyNames method of Lib/Properties.lua.
  • Fix unsafe name errors: When generating a "safe name" for Instances whose names contain solely unsafe characters, Codify would error out. This closes #21 by mapping unsafe characters to a lowercase alphabet.
  • Omit Instance types: If the property's value type is an Instance, it will be omitted from the resulting snippet.
    This does not close #18, but is a temporary fix for this. This will be reassessed later to allow the vanilla snippets to reference Instances if they are in scope.
  • Respect original name: When generating snippets that include the .Name property of Instances, the name will now be the same as the original Instance's name, rather than being converted to camelCase.
  • Swap Llama for Sift: Llama's now deprecated. Switched to Sift.
  • Instance Omission Feedback: A message is now displayed on the home tab to inform users that Instance-based properties will be excluded from the output.

When generating a "safe name" for Instances whose names contain solely unsafe characters, Codify would error out.

This closes #21 by mapping unsafe characters to a lowercase alphabet.
If the property's value type is an Instance, it will be omitted from the resulting snippet.

This does not close #18, but is a temporary fix for this. This will be reassessed later to allow the vanilla snippets to reference Instances if they are in scope.
@cxmeel cxmeel self-assigned this May 17, 2022
@cxmeel cxmeel marked this pull request as ready for review May 17, 2022 13:02
This partially closes #20 by informing users that Instance-based properties are omitted, but I'd like to revisit either the style or implementation of this in future.
@cxmeel cxmeel linked an issue May 17, 2022 that may be closed by this pull request
@cxmeel cxmeel added bug Something isn't working enhancement New feature or request labels May 17, 2022
@cxmeel cxmeel merged commit a7c23a8 into main May 17, 2022
@cxmeel cxmeel deleted the bugfix branch May 17, 2022 17:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
1 participant