New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMGKit.new fails on url' with ampersand #74
Comments
Man I'm facing the same issue. Did you find any solution? |
I mentioned this in the post.. It's not ideal, but it works.
html = b.url.split('?')[0] I'm sure there's a better way, it's something I've done back in february, if I were to approach this again I'd do it different. |
@pacMakaveli I don't see a problem on doing that. In fact, that's what pdfkit gem did. |
I don't see a valid reason why IMGKit should fail because of that.
Removing ? : It really depends on your use of IMGKit.. Where I use it, escaping the URL becomes a pain and sometimes fails. |
@Ricardonacif your pull request is exact what is needed. Hopefully will be merged in soon. |
Hello,
So this is a weird one and one that gave me a couple of headaches.
Why is
IMGKit
failing when given url's contain ampersands(&) ?I know I can 'sanitize' the URL to remove the ampersand. However, I don't want to do it, really.
Here's the log.
Failed example:
Working example:
The text was updated successfully, but these errors were encountered: