Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time is not logged with an "error" log #32

Closed
jonathaningram opened this issue Jun 11, 2014 · 5 comments
Closed

time is not logged with an "error" log #32

jonathaningram opened this issue Jun 11, 2014 · 5 comments

Comments

@jonathaningram
Copy link

Would you consider adding time to the object logged for errors?

Currently logfmt will print out an error looking like this. As you can see there's no indication of when this happened unless one puts the time in the err's message string.

error=true id=4424516491 message="ahh well..."
error=true id=4424516491 line=0 trace="Error: ahh well..."
error=true id=4424516491 line=1 trace="    at Server.<anonymous> (/theproject/src/routes.js:13:14)"
error=true id=4424516491 line=2 trace="    at next (/theproject/node_modules/restify/lib/server.js:731:30)"
error=true id=4424516491 line=3 trace="    at f (/theproject/node_modules/restify/node_modules/once/once.js:16:25)"
error=true id=4424516491 line=4 trace="    at Server.check (/theproject/node_modules/authware/src/middleware.js:82:7)"
error=true id=4424516491 line=5 trace="    at next (/theproject/node_modules/restify/lib/server.js:731:30)"
error=true id=4424516491 line=6 trace="    at f (/theproject/node_modules/restify/node_modules/once/once.js:16:25)"
error=true id=4424516491 line=7 trace="    at Server.parseQueryString (/theproject/node_modules/restify/lib/plugins/query.js:39:17)"
error=true id=4424516491 line=8 trace="    at next (/theproject/node_modules/restify/lib/server.js:731:30)"
error=true id=4424516491 line=9 trace="    at f (/theproject/node_modules/restify/node_modules/once/once.js:16:25)"
@csquared
Copy link
Owner

great suggestion -- i'll get that in there

@jonathaningram
Copy link
Author

awesome thanks!

@csquared
Copy link
Owner

Sorry this took forever!! Just pushed v1.2.0 w. time logged on errors. :)

@csquared
Copy link
Owner

FYI: d99fcd2

@jonathaningram
Copy link
Author

thanks @csquared much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants