Fix race condition #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fs.writeFile(cssOutFilename, css, function(err) { | ||
| if (err) console.error(err); | ||
| fs.writeFile(cssOutFilename, css, function () { | ||
| cb.apply(null, args); |
There was a problem hiding this comment.
Good one, thanks. Could you please update so that cb only gets called if it exists?
tedbreen
force-pushed
the
patch-1
branch
2 times, most recently
from
10a5952
to
074fc05
Compare
Two things:
1) Reverting back to browserify's original bundle method. This method is only intended to take a singular callback argument.
2) stream.on('end', function () {}) creates a race condition. Using a callback in the bundle method instead to resolve this.
|
@joshwnj updated to check if |
|
Thanks! |
|
@tedbreen are you using css-modulesify in production? At some point we'll want to get this to v1.0 so will be good to know who is using it and how :) |
|
leaving a note here for future reference: I had to upgrade browserify to v11 with this version as v10 was having issues. |
|
cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things:
bundlemethod. This method is only intended to take a singular argument (a callback in this case).stream.on('end', function () {})creates a race condition. Using a callback in the bundle method instead to resolve this.