Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect processing of CR LF #147

Closed
Taritsyn opened this issue Oct 17, 2013 · 2 comments
Closed

Incorrect processing of CR LF #147

Taritsyn opened this issue Oct 17, 2013 · 2 comments

Comments

@Taritsyn
Copy link
Contributor

When processing of the following CSS code (intentionally contains an error):

@charset "UTF-8";

html {
    background-color: #e2e2e2;
    margin: 0;
    padding: 0;
}

body {
    background-color: #fff;
    border-top: solid 10px #000;
    color: #333;
    font-size: .85em;
    font-family: "Segoe UI", Verdana, Helvetica, Sans-Serif;
    margin: 0;
    padding: 0;
}

a {
    color: #333;
    outline: none;
    2padding-left: 3px;
    padding-right: 3px;
    text-decoration: underline;
}

If \r\n (CR LF) is used as a newline character, then the following error is displayed:

Please check the validity of the CSS block starting from the line #59 

If \n (LF) is used as a newline character, then the following error is displayed:

Please check the validity of the CSS block starting from the line #30 

Thus, we get a different line numbers depending on which type of newline character is used.

@XhmikosR
Copy link
Contributor

Must be relevant, all tests fail on Windows when I try it.

@lahmatiy
Copy link
Member

Fixed by 8a66cfa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants