-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minifying 0px within calc statements breaks them #222
Comments
@appsforartists Just curious, why would you use a selector such as this (with the div {
width: calc(100vw / 2 - 6px + 0px);
} |
@ben-eb It'd be generated by a tool like SASS if you set a variable to 0px. |
@appsforartists Ideally then, CSSO should minify this to: div {
width: calc(100vw / 2 - 6px);
} Or, just leave it alone. 😄 |
Yup! |
Looks like it is also mangling time values like |
It's breaking |
@azamat-sharapov I maintain https://github.com/ben-eb/cssnano, a modern alternative to CSSO which is based on PostCSS. |
New installs of css-loader use cssnano. 😄 |
You are right. Then I should check if it's cssnano breaking |
@azamat-sharapov Seems it was a regression introduced some time ago. I've added a test for it, try 3.0.2. 😄 |
@ben-eb thanks for the quick fix! it's working now! |
See webpack/webpack#666
Chrome (and probably others) chokes on the unitless
0
incalc
:The text was updated successfully, but these errors were encountered: