Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate properties #278

Closed
MariskaS opened this issue Mar 7, 2016 · 5 comments
Closed

Remove duplicate properties #278

MariskaS opened this issue Mar 7, 2016 · 5 comments

Comments

@MariskaS
Copy link

MariskaS commented Mar 7, 2016

Hello!
If the selector 2 duplicate rules with different properties, if minification is only recently (see the task #257). But I need to remain both rules, as one used to Сhrom and the second for IE11
What to do in this case?

@lahmatiy
Copy link
Member

lahmatiy commented Mar 7, 2016

Can you provide an example?

@MariskaS
Copy link
Author

MariskaS commented Mar 7, 2016

I am use angular-material. This library can meet the selectors with duplicate rules.And of course not only in this library can this be.
http://take.ms/FzN4b
https://github.com/angular/bower-material/edit/master/angular-material.css

@lahmatiy
Copy link
Member

lahmatiy commented Mar 8, 2016

Yep, in this case we need to keep both. CSSO tries to keep properties with different support. In this example CSSO left both (try it here):

.example {
    color: red;
    color: rgba(255, 0, 0, .5);
}

But CSSO doesn't know about start and end special values for text-align and wrongly merge them. That's can be fixed when issue is known. Probably we should rename issue to text-align: start/end problem...

@lahmatiy
Copy link
Member

Problem with text-align is fixed in #281
Closing issue for now, if any similar problem will be found – please, create a separate issue.

@MariskaS
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants