Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New option: rule-delimiter #210

Closed
tonyganch opened this issue Mar 31, 2014 · 86 comments

Comments

@tonyganch
Copy link
Member

commented Mar 31, 2014

Moved from #209:

I guess we should add an option like rule-delimiter which will set spaces between rulesets and media queries (this has been already discussed in #92).
It seems to me that this option should be more important than space-after-declaration (see #197).
So we can have, for example: { 'space-after-declaration': 1, 'rule-delimiter': '\n\n' }

// Before
a {
    color: tomato;
    top: 0;
    panda {
        position: happy;
    }
    raccoon {
        a: b;
    }
    foo: bar;
}
div {
    border: none;
}

// After
a {
    color: tomato; top: 0;

    panda {
        position: happy;
    }

    raccoon {
        a: b;
    }

    foo: bar;
}

div {
    border: none;
}

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/1519010-new-option-rule-delimiter?utm_campaign=plugin&utm_content=tracker%2F214563&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F214563&utm_medium=issues&utm_source=github).
@tonyganch

This comment has been minimized.

Copy link
Member Author

commented Mar 31, 2014

Alas, there is no way to achieve this with current settings.
We need to introduce new options to make this work.

@evenicoulddoit

This comment has been minimized.

Copy link

commented Jun 6, 2014

Big +1 from me. I just spent quite a while manually adding new lines in!

@lefoy

This comment has been minimized.

Copy link

commented Jun 9, 2014

Is this implemented with the new V3? I can't find the option in the docs.
#214

@tonyganch

This comment has been minimized.

Copy link
Member Author

commented Jun 9, 2014

Is this implemented with the new V3?

@lefoy, nope

@lefoy

This comment has been minimized.

Copy link

commented Jun 9, 2014

Any idea when this will be implemented? Is it planned for the stable V3 release?

@mbrammer

This comment has been minimized.

Copy link

commented Jun 13, 2014

+1 from my side

@dankempster

This comment has been minimized.

Copy link

commented Jun 26, 2014

+1 would love this

@hanakin

This comment has been minimized.

Copy link

commented Jun 27, 2014

+1

@marijnvdwerf

This comment has been minimized.

Copy link

commented Jun 27, 2014

+1 from me too

@jonathan-fielding

This comment has been minimized.

Copy link

commented Jul 7, 2014

Hello, do we have an ETA for this? would be awesome

@tonyganch

This comment has been minimized.

Copy link
Member Author

commented Jul 8, 2014

There is no ETA for this option.
But you can help by sending a PR.

@somerandomdude

This comment has been minimized.

Copy link

commented Jul 11, 2014

Huge +1.

@znamilya

This comment has been minimized.

Copy link

commented Jul 12, 2014

+1

@nitrium

This comment has been minimized.

Copy link

commented Jul 24, 2014

+1, would love to have this

@thebugs

This comment has been minimized.

@denisborovikov

This comment has been minimized.

Copy link

commented Jul 25, 2014

@thebugs I think it should accepts number of lines as parameter, not boolean.

@lefoy

This comment has been minimized.

Copy link

commented Jul 25, 2014

+1 for number of lines instead of boolean

@thebugs

This comment has been minimized.

Copy link

commented Jul 25, 2014

I've updated gist. Now it accepts number of lines as parameter

@denisborovikov

This comment has been minimized.

Copy link

commented Jul 25, 2014

@thebugs Thank you! Good job!

@FernE97

This comment has been minimized.

Copy link

commented Jul 29, 2014

@thebugs Thanks! Looks like there is a small issue though if you run csscomb more than once it keeps adding an extra line below the rule, so if you run it 3 times there are three blank lines under each rule.

@thebugs

This comment has been minimized.

Copy link

commented Jul 30, 2014

@FernE97 I use only scss. So if there are issues with other syntax - sorry.

@FernE97

This comment has been minimized.

Copy link

commented Jul 31, 2014

@thebugs I am using scss as well and that is where I'm noticing the issue. Wonder if there is something in my .csscomb.json config file that is conflicting with it.

Here is my config file minus the huge sort-order array.

{
    "remove-empty-rulesets": true,
    "always-semicolon": true,
    "color-case": "lower",
    "block-indent": "    ",
    "color-shorthand": true,
    "element-case": "lower",
    "eof-newline": true,
    "leading-zero": true,
    "quotes": "single",
    "sort-order-fallback": "abc",
    "space-before-colon": "",
    "space-after-colon": " ",
    "space-before-combinator": " ",
    "space-after-combinator": " ",
    "space-between-declarations": "\n",
    "space-before-opening-brace": " ",
    "space-after-opening-brace": "\n",
    "space-after-selector-delimiter": "\n",
    "space-before-selector-delimiter": "",
    "space-before-closing-brace": "\n",
    "strip-spaces": true,
    "tab-size": true,
    "unitless-zero": true,
    "vendor-prefix-align": true,
    "rules-delimiter": 1
}
@NikolaMalich

This comment has been minimized.

Copy link

commented Jul 11, 2015

+1 would really love to see this

@SpencerCarstens

This comment has been minimized.

Copy link

commented Jul 29, 2015

What is the current status on this?

How can I help make this a thing?

@lstanard

This comment has been minimized.

Copy link

commented Jul 31, 2015

+1

@tonyganch

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2015

@SpencerCarstens, the most recent pr is #405

@banricho

This comment has been minimized.

Copy link

commented Aug 5, 2015

+1

1 similar comment
@nvartolomei

This comment has been minimized.

Copy link

commented Aug 6, 2015

+1

@evgenTraytyak

This comment has been minimized.

Copy link

commented Aug 18, 2015

+1

1 similar comment
@debbiechiang

This comment has been minimized.

Copy link

commented Aug 19, 2015

+1

@zellwk

This comment has been minimized.

Copy link

commented Aug 24, 2015

+1

10 similar comments
@mwyatt

This comment has been minimized.

Copy link

commented Aug 24, 2015

+1

@testerix1

This comment has been minimized.

Copy link

commented Aug 30, 2015

+1

@oranj

This comment has been minimized.

Copy link

commented Aug 31, 2015

+1

@brunnolou

This comment has been minimized.

Copy link

commented Sep 4, 2015

+1

@galengidman

This comment has been minimized.

Copy link

commented Sep 8, 2015

+1

@siriniok

This comment has been minimized.

Copy link

commented Sep 10, 2015

+1

@alexkwa

This comment has been minimized.

Copy link

commented Sep 17, 2015

+1

@andrade1379

This comment has been minimized.

Copy link

commented Sep 18, 2015

+1

@zhe

This comment has been minimized.

Copy link

commented Sep 22, 2015

+1

@rastersysteme

This comment has been minimized.

Copy link

commented Sep 24, 2015

+1

@csscomb csscomb locked and limited conversation to collaborators Sep 29, 2015

@tonyganch

This comment has been minimized.

Copy link
Member Author

commented Sep 29, 2015

I'm temporarily locking the conversation to avoid more +1's.
If anyone feels like helping, please refer to the open pr: #405
Thank you.

@sodatea sodatea added status: fixed and removed help wanted labels Feb 15, 2016

@tonyganch tonyganch removed this from the Next release milestone Jul 11, 2016

@tonyganch tonyganch removed the preprocessors label Aug 3, 2016

@jdalton jdalton closed this Apr 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
You can’t perform that action at this time.