Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with eof-newline #572

Open
line47 opened this issue Jan 18, 2018 · 3 comments
Open

Issue with eof-newline #572

line47 opened this issue Jan 18, 2018 · 3 comments

Comments

@line47
Copy link

line47 commented Jan 18, 2018

I'd expect the results of "eof-newline": true to put a newline after every https://github.com/csscomb/csscomb.js/blob/dev/doc/options.md#eof-newline

However that is not happening when I run CSS Comb on an entire file.

Here is my config:

{
    "exclude": [
        ".git/**",
        "node_modules/**",
        "bower_components/**"
    ],
    "always-semicolon": true,
    "block-indent": "  ",
    "color-case": "lower",
    "color-shorthand": true,
    "element-case": "lower",
    "include": true,
    "eof-newline": true,
    "leading-zero": false,
    "quotes": "single",
    "remove-empty-rulesets": true,
    "space-after-colon": " ",
    "space-after-combinator": " ",
    "space-after-opening-brace": "\n",
    "space-after-selector-delimiter": "\n",
    "space-around-operator": " ",
    "space-before-closing-brace": "\n",
    "space-before-colon": "",
    "space-before-combinator": " ",
    "space-before-opening-brace": " ",
    "space-before-selector-delimiter": "",
    "space-between-declarations": "\n",
    "strip-spaces": true,
    "tab-size": true,
    "unitless-zero": true,
    "vendor-prefix-align": true,
    "sort-order": [ "..." ],
    "sort-order-fallback": "abc"
  }

Here is my SCSS before running CSS Comb:

.label-success {
  background-color: $label-success-bg-color;
}
.label-danger {
  background-color: $label-danger-bg-color;
}
.label-warning {
  background-color: $label-warning-bg-color;
}

Here is my SCSS after running CSS Comb: (no change 😢 )

.label-success {
  background-color: $label-success-bg-color;
}
.label-danger {
  background-color: $label-danger-bg-color;
}
.label-warning {
  background-color: $label-warning-bg-color;
}

What am I missing here?

@anton-dubrovin
Copy link

anton-dubrovin commented Jan 19, 2018

Hello,
we have the same issue with eof newline. I get css something like this:

.ksf-field-box .ksf-field-box__title {
	margin-bottom: 1.2em;

	font-weight: 500;
}.ksf-field-box .ksf-field-box__desc {
	color: #989CB3;
}.ksf-field-box .ksf-field-box__main {
	display: flex;
	align-items: flex-start;
	flex-wrap: wrap;

	max-width: 840px;
	margin: -10px;
}

@jdalton
Copy link
Contributor

jdalton commented Apr 26, 2019

Hi @line47, @kraftstudio

Are either of you on Windows?

@line47
Copy link
Author

line47 commented Apr 26, 2019

Hey @jdalton not I. I'm on Mac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants