Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console.warn stops CSScomb #34

Closed
tonyganch opened this issue Aug 14, 2014 · 1 comment
Closed

console.warn stops CSScomb #34

tonyganch opened this issue Aug 14, 2014 · 1 comment

Comments

@tonyganch
Copy link
Member

If for some reason there is an unacceptable value in user's config, CSScomb prints a warning to console:

try {
    addHandler(options[optionName], config[optionName]);
 } catch (e) {
    // Show warnings about illegal config values only in verbose mode:
    if (verbose) {
        console.warn('\nFailed to configure "%s" option:\n%s', optionName, e.message);
    }
}

Errors are thrown within setValue function: https://github.com/csscomb/core/blob/master/lib/core.js#L101

@corvannoorloos says that instead of just printing a warning Grunt plugin also "discontinues the task (the files aren't being modified after this notice)".

@noahcooper
Copy link
Collaborator

I'm not able to reproduce the issue described. console.warn does not appear to cause Grunt to exit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants