Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple fallbacks for the same property name not working #1177

Closed
maxcelima opened this issue Aug 21, 2019 · 4 comments · Fixed by #1198
Closed

Multiple fallbacks for the same property name not working #1177

maxcelima opened this issue Aug 21, 2019 · 4 comments · Fixed by #1198
Labels
bug It went crazy and killed everyone.

Comments

@maxcelima
Copy link

Expected behavior:
When an array is used for the fallbacks value it should render multiple properties for the same property name

Describe the bug:
The array of fallbacks are being render like this:

.Component-withFallbacks-2-2-1 {
  0: [;
  1: o;
  2: b;
  3: j;
  ...
  29: c;
  30: t;
  31: ];
  display: flex;
}

The jss vendor prefix plugin seems to be changing it into the string
"[object Object], [object Object]"

Codesandbox link:
https://codesandbox.io/s/jss-fallbacks-problem-gbvkf

Versions (please complete the following information):

  • jss: 10.0.0-alpha.24
  • Browser: Chrome
  • OS Windows and macOS
@kof kof added the bug It went crazy and killed everyone. label Sep 22, 2019
@kof
Copy link
Member

kof commented Sep 22, 2019

I confirm, something in react-jss or in plugins breaks this, core works as expcted.

@kof
Copy link
Member

kof commented Sep 22, 2019

Also it turns out to be a regression compared to v8

@kof
Copy link
Member

kof commented Sep 22, 2019

Turns out we forgot to handle fallbacks in jss-plugin-vendor-prefixer after we decided to kick them out of vendor-prefixer as a jss specific syntax.

Now I wonder if fallbacks should be prefixed at all or left as-is.

@kof
Copy link
Member

kof commented Sep 22, 2019

Made fallbacks to get prefixed.

@kof kof closed this as completed in #1198 Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It went crazy and killed everyone.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants