Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CSS TypeScript types on createUseStyles #1351

Closed
moshest opened this issue Jun 9, 2020 · 6 comments
Closed

Support CSS TypeScript types on createUseStyles #1351

moshest opened this issue Jun 9, 2020 · 6 comments
Labels
typescript

Comments

@moshest
Copy link
Member

moshest commented Jun 9, 2020

This feature is related to the rollback made for issue #1255

The fix was to rollback to previous version and now every IDEA autocomplete is broken when writing createUseStyles.

Rollback change: #1270

Any plan to fix that soon?
@moshest moshest changed the title Support CSS types on createUseStyles Support CSS TypeScript types on createUseStyles Jun 9, 2020
@kof
Copy link
Member

kof commented Jun 9, 2020

Feel free to fix it, I will merge it but then you will have to deal with follow up problems. If you are willing to do that 👍

Alternatively, I can move out TS types off core back to definitely typed and it can be released independently.

@kof kof added the typescript label Jun 9, 2020
@moshest
Copy link
Member Author

moshest commented Jun 9, 2020

Can you elaborate more about those problems?

What's wrong with the implementation previously on #1270?

@kof
Copy link
Member

kof commented Jun 9, 2020

I can't, it's just that TS types are not in a good shape and every change seems to result in new issues and I don't have time to maintain it.

@moshest
Copy link
Member Author

moshest commented Jun 9, 2020

OK, I will take a look later on.

@moshest moshest mentioned this issue Jun 9, 2020
Merged
3 tasks
@moshest
Copy link
Member Author

moshest commented Jun 9, 2020

released a PR here: #1352

@kof
Copy link
Member

kof commented Jun 10, 2020

released in v10.3.0

@kof kof closed this as completed Jun 10, 2020
@ITenthusiasm ITenthusiasm mentioned this issue Mar 10, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kof @moshest