Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react-jss] Add flowtype support #797

Closed
HenriBeck opened this issue Aug 3, 2018 · 4 comments
Closed

[react-jss] Add flowtype support #797

HenriBeck opened this issue Aug 3, 2018 · 4 comments
Labels
complexity:low You can fix it, c'mon! enhancement No kittens die if we don't do that. feature request This will safe many lifes!

Comments

@HenriBeck
Copy link
Member

From @HenriBeck on July 6, 2018 18:38

As the jss libary is already using flow, we could add flow to this one as well.

Copied from original issue: cssinjs/react-jss#274
@HenriBeck HenriBeck added the feature request This will safe many lifes! label Aug 3, 2018
@HenriBeck
Copy link
Member Author

Probably won't be in the near future as I'm currently working on migrating the plugin repos to the monorepo.

@HenriBeck
Copy link
Member Author

From @gomesalexandre on July 9, 2018 13:49

@kof I would like to contribute the flow support for this repo, is it something that you would be interested in ?

@HenriBeck
Copy link
Member Author

Sure, go ahead. Create a PR and we will review it.

@HenriBeck HenriBeck changed the title Add flowtype support [react-jss] Add flowtype support Aug 3, 2018
@HenriBeck HenriBeck added enhancement No kittens die if we don't do that. complexity:low You can fix it, c'mon! labels Aug 3, 2018
@TrySound TrySound mentioned this issue Sep 4, 2018
Closed
13 tasks
@HenriBeck
Copy link
Member Author

Implemented in #818

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity:low You can fix it, c'mon! enhancement No kittens die if we don't do that. feature request This will safe many lifes!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HenriBeck