Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jss-global] Link option does not work #664

Closed
aslafy-z opened this issue Jan 18, 2018 · 10 comments
Closed

[jss-global] Link option does not work #664

aslafy-z opened this issue Jan 18, 2018 · 10 comments
Labels
bug It went crazy and killed everyone. plugin When unplugged is fine

Comments

@aslafy-z
Copy link

aslafy-z commented Jan 18, 2018

I'm unable to use the link option mentioned in the JS api documentation with jss-global plugin. Every call to sheet.update after sheet.attach have been called triggers a

Warning: Rule is not linked. Missing sheet option "link: true".

even with the right option, and sheet doesn't get refreshed.

I have been able to reproduce this behavior here: https://codesandbox.io/s/vml5lxmvy

Could be the same as #602 but op didn't said about the link option usage.

@kof
Copy link
Member

kof commented Jan 18, 2018

Thank you for the report, I will take a look asap. In the mean time if you can, you can also try to fix it and send me pr or clues :)

@kof kof added the bug It went crazy and killed everyone. label Jan 18, 2018
@sambhav-gore
Copy link

sambhav-gore commented Jan 18, 2018

@kof I have a solution for this, want to submit a PR but stuck with linting issues.
I never used flow before actually.

@kof
Copy link
Member

kof commented Jan 21, 2018

Ok, send a PR with lint errors, I will take a look.

@sambhav-gore
Copy link

@kof I already created a PR with lint errors fixed - #666

@Vadorequest
Copy link

I have this warning with react-jss@8.2.1 and I have no idea what it may break or so.

@carlgunderson
Copy link

@kof is there an update on this issue based on #666? I'm getting the same warning but I'm not using an option called link anywhere, and can't find it mentioned in any docs...I'm using react-jss with jss-preset-default and this just started showing up. I don't have any dynamic properties inside my @global blocks.

@kof
Copy link
Member

kof commented Feb 13, 2018

@carlgunderson as you can see that PR hasn't been worked on, I am still waiting for @sambhav-gore to finish it. Incase you don't have dynamic props and see this warning, please create a codesandbox demo

@jpetitcolas
Copy link

I encountered a similar issue with a non global scope (see details on mui/material-ui#10543 / sandbox: https://codesandbox.io/s/lpm6vop66l). May it be related?

@kof kof added the plugin When unplugged is fine label Mar 19, 2018
@aslafy-z
Copy link
Author

aslafy-z commented Jul 30, 2018

https://github.com/cssinjs/jss-global/pull/6 for reference

@aslafy-z
Copy link
Author

This issue has been fixed with #1040.
Thanks @kof!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It went crazy and killed everyone. plugin When unplugged is fine
Projects
None yet
Development

No branches or pull requests

6 participants