Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support values ending in !important #23

Closed
Krinkle opened this issue Sep 16, 2014 · 2 comments
Closed

Support values ending in !important #23

Krinkle opened this issue Sep 16, 2014 · 2 comments

Comments

@Krinkle
Copy link
Member

Krinkle commented Sep 16, 2014

Input:

.foo {
  left: 10px !important;
  float: left !important;
  padding: 1px 2px 3px 4px !important;
}

Expected:

.foo {
  right: 10px !important;
  float: right !important;
  padding: 1px 4px 3px 2px !important;
}

Actual:

.foo {
  right: 10px !important;
  float: right !important;
  padding: 1px 2px 3px 4px !important;
}

The padding rule isn't flipped.

@Krinkle Krinkle changed the title Values ending in !important should not be ignored Support values ending in !important Sep 17, 2014
@Krinkle
Copy link
Member Author

Krinkle commented Sep 17, 2014

This is a regression caused by 2f7f368 which stopped flipping properties with too many values (e.g. five or more consecutive values). But since !important isn't being recognised as a special value, properties with it are no longer flipped.

@mattflaschen
Copy link
Member

I'll port the PHP fix over here.

mattflaschen pushed a commit to mattflaschen/node-cssjanus that referenced this issue Oct 9, 2014
mattflaschen pushed a commit to mattflaschen/node-cssjanus that referenced this issue Oct 21, 2014
mattflaschen pushed a commit to mattflaschen/node-cssjanus that referenced this issue Oct 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants