Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid flipping "ltr" or "left" in a data URI #60

Closed
trevorparscal opened this issue May 23, 2018 · 1 comment
Closed

Avoid flipping "ltr" or "left" in a data URI #60

trevorparscal opened this issue May 23, 2018 · 1 comment
Labels
Status: Exported Exported to https://phabricator.wikimedia.org Type: Problem

Comments

@trevorparscal
Copy link
Contributor

trevorparscal commented May 23, 2018 •
edited by Krinkle

Any URL that looks like a data URI should be skipped over. Otherwise image data will occasionally be corrupted, and in the case of the PHP port I've already seen the regular expressions engine simply blank out the entire stylesheet trying to operate on a data URI which was especially large.

Test case
@Krinkle Krinkle changed the title URL ltr/rtl left/right transformation operates on data URIs Avoid flipping "ltr" or "left" in a data URI Sep 24, 2021
@Krinkle Krinkle added the Status: Exported Exported to https://phabricator.wikimedia.org label Mar 28, 2023
@Krinkle
Copy link
Member

Krinkle commented Mar 28, 2023

Exported to https://phabricator.wikimedia.org/T333275.

@Krinkle Krinkle closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Exported Exported to https://phabricator.wikimedia.org Type: Problem
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trevorparscal @Krinkle