-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.0.0-rc.1 doesn't seem to apply #385
Comments
Hmm... After updating other packages it seems that Completely disabling cssnano in postcss gives the same 121KB for the largest stylesheet as with v4. When doing an Oh, btw: with v4 installed:
That's a lot of extra packages, has v3 that much more dependencies than v4? |
Hi, Yeah this is entirely possible as we do less by default; I think autoprefixer was a large contributor to space saved so as it has been removed then it's likely that vendor prefixes have returned to your CSS file. Overall I think the change is for the better for the defaults but you can always load the advanced preset which still retains this behaviour (with others). From the release notes:
Note that cssnano does not take any options any more, they are handled by each preset instead. Yeah, it's also possible that 3.10.0 contains more dependencies, I did try and remove some and consolidate others with the new code. But I don't have a breakdown of what was removed other than the commit history I'm afraid. |
Context: I'm using postcss combined with autoprefixer, cssnano and some other plugins within a webpack setup.
When switching from 3.10.x (packaged with css-loader) to 4.0.0-rc.1 I went from a 20% decrease to an 10% increase of my CSS... Any idea how that might be happening? Removed cssnano from my package.json for now, and all seems fine apart from the
Node#moveTo was deprecated. Use Container#append.
warning.I'm on the latest postcss & postcss-loader, and run autoprefixer (together with other plugins) through it successfully.
PS: I do use the following config.
The text was updated successfully, but these errors were encountered: