Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: postcss-normalize-unicode add browserslist to dependencies #577

Merged

Conversation

jbudz
Copy link
Contributor

@jbudz jbudz commented Aug 6, 2018

browserselist is imported here but not in the package's dependency list

@coveralls
Copy link

coveralls commented Aug 6, 2018

Coverage Status

Coverage remained the same at 98.584% when pulling 9ec3882 on jbudz:dependencies/postcss-normalize-unicode into 252c3eb on cssnano:master.

@andyjansson
Copy link
Contributor

Can you bump it down to the same version we're using in the other packages (4.0.0)? We'd prefer not keeping multiple versions of the same package.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read comment above, thanks!

@jbudz
Copy link
Contributor Author

jbudz commented Aug 7, 2018

thanks for the review! pushed in 8ed6559. as a heads up I had to manually edit the yarn.lock due to the ^'s that are on newer versions now

@jbudz jbudz force-pushed the dependencies/postcss-normalize-unicode branch from d86dcb4 to 8ed6559 Compare August 7, 2018 13:59
@jbudz jbudz force-pushed the dependencies/postcss-normalize-unicode branch from 8ed6559 to 9ec3882 Compare August 8, 2018 02:35
@ianwalter
Copy link
Contributor

@jbudz @evilebottnawi It seems to me that the same issue is in postcss-minify-params as well.

@alexander-akait alexander-akait merged commit 39ec020 into cssnano:master Aug 30, 2018
@alexander-akait
Copy link
Member

@ianwalter please send a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants