Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] When is the next release? #979

Closed
henricook opened this issue Jan 8, 2021 · 10 comments
Closed

[Feature Request] When is the next release? #979

henricook opened this issue Jan 8, 2021 · 10 comments
Milestone

Comments

@henricook
Copy link

henricook commented Jan 8, 2021

Hi cssnano team,

We recently spent quite some time trying to figure out why an opacity: 50% wasn't working on a remote deployment but was working locally, the answer was remotely we have a build process that uses css nano and the opacity was getting converted to 1% because of a bug

I noticed this is fixed in a merged MR but there's not been a release since 2019 - would you be able to release soon to prevent others going through this pain?

MR I refer to: #881

@alexander-akait
Copy link
Member

@ludofischer @anikethsaha Should we do something for our playground, we migrate on PostCSS 8 so I think we can do release

@anikethsaha
Copy link
Member

anikethsaha commented Jan 11, 2021

yea, dependencies update and changes in this file https://github.com/cssnano/cssnano/blob/master/site/src/components/editor/postcss_runner.js
not much it should be similar to the one done in cssnano's core runner

@ludofischer
Copy link
Collaborator

I've managed to go as far as publishing a 5.0.0-alpha.0 GitHub release https://github.com/cssnano/cssnano/releases and generated a changelog on this branch https://github.com/cssnano/cssnano/tree/5.x.x. But I definitely lack the permissions to publish on npm.

@anikethsaha
Copy link
Member

great.
here is my twitter handle https://twitter.com/__ANIX__, ping me there I will give permission for cssnano-bot. and then you can do the release using lerna
Also, I am submitting a PR to delete deprecated packages. we need to include that before release

@anikethsaha
Copy link
Member

@ludofischer ⬆️

@ludofischer
Copy link
Collaborator

Are you also going to update the website or do you prefer I submit a pull request for that?

@anikethsaha
Copy link
Member

I guess we can update the website after release. Its just updating the dep version and then running the deploy script

@ludofischer
Copy link
Collaborator

My idea would be

  1. publish a release candidate
  2. update the website and the playgound to use the release candidate
  3. publish final if nothing breaks

How should we handle the repository branches? We can't change master without a review, so I was thinking of updating the package.json version in a separate branch, then opening a pull request to merge it to master. Also I think we can skip the currently tagged alpha as it includes the css-util packages that have been deleted in the mean time.

@ludofischer
Copy link
Collaborator

ludofischer commented Feb 19, 2021

The next release candidate (cssnano 5.0.0-rc.0) is available on npm on the next branch.

@ludofischer ludofischer added this to the 5.0.0 milestone Mar 5, 2021
@ludofischer ludofischer removed the triage label Mar 7, 2021
@ludofischer
Copy link
Collaborator

cssnano 5.0.0 has been published to npm: https://www.npmjs.com/package/cssnano/v/5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants