Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some sites not scraping properly #256

Open
wesort opened this issue Feb 18, 2019 · 7 comments
Open

Some sites not scraping properly #256

wesort opened this issue Feb 18, 2019 · 7 comments
Labels

Comments

@wesort
Copy link

wesort commented Feb 18, 2019

Some sites aren't being scanned properly. These are server rendered and use standard CSS so not sure why this is the case.

My own site for example:

This client site:

@znerd
Copy link

znerd commented Apr 11, 2019

Here is another example:

Stylesheet:

Note that the stylesheet is 534 KB (uncompressed), but according to CSSStats, it only has:

  • 5 rules
  • 5 selectors
  • 15 declarations
  • 12 properties
  • 2 unique colors
  • 1 unique font size

@kommaRob
Copy link

kommaRob commented May 3, 2019

I have the same issue with some sites. Very weird.

@sheriffderek
Copy link

Here's a style-guide that should kinda mirror the results (for a test)
https://thisisthegoldcollective.com/style-guide

Screen Shot 2019-07-26 at 8 59 36 AM

It builds the URL with a missing / - and breaks.
Screen Shot 2019-07-26 at 8 59 43 AM

When you add the missing /it doesn't fail / but it also doesn't scrape the main CSS

Screen Shot 2019-07-26 at 9 00 16 AM

Could it be the version tripping it up?

Screen Shot 2019-07-26 at 9 01 58 AM

@johno johno added the bug label Jul 26, 2019
@philwolstenholme
Copy link

philwolstenholme commented Jul 27, 2019

Ah, this would explain why none of my Drupal sites work with this tool too. Seems #264 might be related.

@sheriffderek
Copy link

It seems like the query string should replace the / with whatever that character code is... but 9/10 sites I tried didn't work at all - and the few that did - didn't seem to work well - and none of the issues have been addressed since 2015... so - I'm not sure what the point of trying to sort it out is. I'll go back to just believing that I'm perfect instead. ; )

@johno
Copy link
Member

johno commented Jul 28, 2019

It seems like the query string should replace the / with whatever that character code is

This was indeed a bug in the latest version which has now been fixed.

none of the issues have been addressed since 2015

I've left the issues open where folks have reported errors if there's still at least a url listed amongst the comments that isn't working. That also said, this is a free, open source project that we work on in our very limited free time. We can't address all bugs promptly.

Your patience is appreciated.

PRs welcome ❤

@sheriffderek
Copy link

Sorry to poke at you! Maybe there's a way to keep a list of these things without making it seem like it's abandoned. Maybe some visual flag. : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants