-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Except doesn't work as expected #3
Comments
I can second this. I cloned the repository and put in the following test scenario into the .tape.js to verify the issue. Test case
Reported result:
It appears to be the case that it does a prop2 replacement, despite that they're both listed as exemptions. Reason for errorInside the code we map prop2 and prop4 conversion. These are not covered by the except. Proposal for solutionAdd checks for prop2 and prop4. If any of the except properties are identified, skip prop2/prop4 conversion and instead rely on one-to-one conversion. Bonus, if prop2 and prop4 has feature flags and may be opted out of through configuration. |
I have the same problem using
and still getting
This issue is more than one year old, just like a pull request from October last year. |
@jens-duttke I've started fixing the bugs and ensure its too standard over here https://github.com/Jordan-Hall/stylelint-use-logical-spec. I'll link this issue so i can resolve it |
I have kind of the same problem. My config:
The style:
This is raising an error. but this style is not:
So it seems having both of the padding-top and padding-bottom is not supported by the |
This has been fixed. |
Version of stylelint-use-logical
1.1.0
Config
Code
Error
Expected
No error because
top
property is added to theexpect
array.The text was updated successfully, but these errors were encountered: