Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-english quotes are ignored on <q> tag #109

Closed
pim opened this issue Jan 14, 2013 · 3 comments
Closed

Non-english quotes are ignored on <q> tag #109

pim opened this issue Jan 14, 2013 · 3 comments

Comments

@pim
Copy link

pim commented Jan 14, 2013

Hey,

When I set $english-quotes to true in _vars.scss and then set my custom opening and closing quotes they get ignored when it I use <q> tag even though they work in <blockquote>. After changing line 21 of _quotes.scss to look exactly like line 43 it works fine.

Just a reminder: we discussed it on Twitter and came to some conclusions.

Cheers :)

@csswizardry
Copy link
Owner

Easier to discuss this stuff here than on Twitter…

Lines 7–10 of _quotes.scss should not be modified; they only exist due to what I see as a flaw in Sass.

Quotes should only get defined by a user in _vars.scss, but because of how Sass handles variables defined in conditionals we have to also define the variable in cases where it wouldn’t get set by the @if.

@pim
Copy link
Author

pim commented Jan 14, 2013

Sure, I didn't even touch _quotes.scss. To be precise, I added something like this to my main Sass file to make it work:

q{
    quotes: "#{$open-quote}" "#{$close-quote}";
}

We should keep in mind that my language (Polish) practically uses only one type of quotes.

@csswizardry
Copy link
Owner

Please see #291.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants