-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make inuit.css ready for responsive type and responsive spacing #118
Comments
Just ran into this issue and came here to suggest something like this. The code you have here @kernfruit solves the majority of the issues with maintaining proportions and scaling the type, but the issue I'm running into is that I'm using the I began to write a mixin that accepts a property/value pair to write it with the rem measurement and a fallback but it was quickly becoming far too complex to be practical. I think a good solution might be to have a px and rem based variable for each of those spacing units. |
What about ems? Inuit doesn't really play well with them, I feel. |
Agree with you guys, this is something I'd really like too, not just in type but everywhere. As I always feel icky editing the Inuit code directly I generally do overrides in my own files. I pass the
|
@patocallaghan i have the same approach of passing in the var into a em() function. For me I find one bonus of having the variables in pixels is it's easier to do sass math on them like adding, subtracting and then use the final value in the css with a em() function wrapped around them. @wfendler this is a good rem mixin https://gist.github.com/webgefrickel/4530526 |
Please see #291. Thank you. |
For responsive design it's sometimes important to change font-sizes and spacing-units at a certain breakpoint.
The use of rems is wonderful for this approach: You are able to set the font-size on the html-element to 150% and all rem-units on the site will be increased by this factor.
For font-sizes it's already there but wouldn't it be nice to add the following rem functionality presented in _shared.scss to ALL $base/half-spacing-units?
The text was updated successfully, but these errors were encountered: