Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoderInputStream#close() doesn't close the wrapped InputStream #1

Open
Scottmitch opened this issue Nov 16, 2016 · 1 comment
Open

Comments

@Scottmitch
Copy link

Scottmitch commented Nov 16, 2016

CoderInputStream wraps an InputStream but does not manage the lifetime of that InputStream [1]. this is generally common practice (e.g. BufferedInputStream, GZIPInputStream, etc...), and may lead to resource leaks if the underlying stream is not managed externally to the CoderInputStream. Is there a reason why the lifetime of the wrapped stream is not managed?

[1] https://github.com/cstamas/streams/blob/master/src/main/java/org/cservenak/streams/CoderInputStream.java#L80

@Scottmitch
Copy link
Author

related to jponge/lzma-java#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant