Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WALC 0.2.0 redirects to Google Chrome Update after a Whatsapp update today. #138

Closed
bkmo opened this issue May 3, 2021 · 26 comments · Fixed by #139
Closed

WALC 0.2.0 redirects to Google Chrome Update after a Whatsapp update today. #138

bkmo opened this issue May 3, 2021 · 26 comments · Fixed by #139
Labels
bug Something isn't working

Comments

@bkmo
Copy link

bkmo commented May 3, 2021

I am being shown the Update Google Chrome page after getting a new WhatsApp update notice today. Using the new 0.2.0 appimage on arch linux KDE.

@bkmo bkmo added the bug Something isn't working label May 3, 2021
@tsjk
Copy link

tsjk commented May 4, 2021

I have the same. Would be nice to know how to revert the update.

@Zzombiee2361
Copy link
Collaborator

Ok this must be from the new electron-forge version, try using the same version but compiled with electron-builder. Works for me, and without the notification bug

@bkmo
Copy link
Author

bkmo commented May 4, 2021

Yes, the electron-builder version does not ask for Chrome update. Thanks

@tsjk
Copy link

tsjk commented May 4, 2021

If I click "update WhatsApp" it asks for Chrome update regardless. I take backups of my home directory quite often, and restoring ~/.config/walc made WALC usable again. Not clicking doesn't really help though, as restarting the app again puts it in a non-usable state. And, I'm using that electron-builder-version.

@tsjk
Copy link

tsjk commented May 4, 2021

Downgrading to 0.1.11 works well, then I can get past the "update WhatsApp". And, that version doesn't ask whether I want to exit when I explicitly click quit or send the process a term signal - which is nice. :)

@mauromol
Copy link

mauromol commented May 6, 2021

I still have this problem although using WALC 0.2.1 (from Snapcraft). Is it normal?

cstayyab added a commit that referenced this issue May 6, 2021
@cstayyab
Copy link
Collaborator

cstayyab commented May 6, 2021

@mauromol Does it still say "Chrome 60+" or does it show some other version number?

@mauromol
Copy link

mauromol commented May 6, 2021

@cstayyab wow, it now works, I don't know why... I have just been keeping it closed since this morning and now it starts... :-\

I confirm this morning it said "Chrome 60+", and I also confirm that it was already updated to version 0.2.1 (I even closed it and reopened a couple of times to make sure that no snap update was still pending).
Perhaps some caching problem? Is there a way to try to "force" a refresh once the application is running? I tried the "old classics" F5 key, but it did nothing.

@cstayyab
Copy link
Collaborator

cstayyab commented May 6, 2021

@mauromol If it was the caching problem then it probably was Snap being running in background (Some snapd mechanism i think) even after you closed it. You just need to check if WALC process is still in the memory and kill it.

@mauromol
Copy link

mauromol commented May 7, 2021

Oh, well, I just started today WALC and I get this again:

image

mauro@hppb ~ $ snap info walc
name:      walc
summary:   WALC - unofficial WhatsApp Linux Client
publisher: Muhammad Tayyab Sheikh (cstayyab)
store-url: https://snapcraft.io/walc
contact:   https://cstayyab.com/contact
license:   unset
description: |
  A WhatsApp Desktop client for Linux systems. This is an unofficial client. Use
  https://web.whatsapp.com for official web client as official desktop client for Linux does not
  exist.
  
  **Source Code:** https://github.com/cstayyab/WALC
  
  **AppImage(All Linux Distributions):** https://github.com/cstayyab/WALC/releases/latest
commands:
  - walc
snap-id:      WZrAWsHcPldM6nqlPpTg25X2NXXXnNA3
tracking:     latest/stable
refresh-date: 2 days ago, at 11:11 CEST
channels:
  latest/stable:    0.2.1 2021-05-04 (19) 69MB -
  latest/candidate: 0.2.1 2021-05-04 (19) 69MB -
  latest/beta:      0.2.1 2021-05-04 (19) 69MB -
  latest/edge:      0.2.1 2021-05-04 (19) 69MB -
installed:          0.2.1            (19) 69MB -

Closed WALC with the upper-right "x", confirmed closing the app, started WALC again and now it started correctly.

Please note that:

  • before starting WALC the first time (which showed the "Chrome 60+" message), the system was restarted completely, so nothing must have been in memory before that
  • after closing WALC I ensured no more "WALC" processes were still running before starting it again (I didn't need to kill anything indeed)

So it's like it's a "hit or miss" whenever I start WALC...

@tsjk
Copy link

tsjk commented May 7, 2021

There was a new update. Version 0.1.11-post got past it without any problems.

@mauromol
Copy link

mauromol commented May 7, 2021

@tsjk I still see version 0.2.1 (the one I'm using) as the latest one, both on Snapcraft and here on GitHub.

@Zzombiee2361
Copy link
Collaborator

@mauromol oh no, what language is that? We do have a mechanic to workaround this issue, but it checks if the string "Update Google Chrome" exists on the page. Since that string doesn't exists, the workaround never fires ¯\_(ツ)_/¯

If anyone has a better way on detecting that update page, go on and open pull request or tell us here

@cstayyab
Copy link
Collaborator

cstayyab commented May 7, 2021

@Zzombiee2361 I updated the UserAgent String after 0.2.1 release and as per my testing this page never even shows. Can you verify the latest code, so may be we can release a bug-fix release?

@mauromol
Copy link

mauromol commented May 7, 2021

@Zzombiee2361 it's Italian. What surprises me is that, as others already said, this problem never occurred with the old WALC version.

I find that searching for the string "Update Google Chrome" is a bit fragile. Perhaps looking at the HTML/CSS structure of that page would be a bit more robust, at least for as long as the Whatsapp web service doesn't change that page with something substantially different...

@Zzombiee2361
Copy link
Collaborator

@cstayyab alright I'll test it

@mauromol probably because of the user agent then. But there is some rare case where you need to unregister the service worker to get it working. When that happens, we need to check for that page, and we do need a reliable way to detect it.

Have you ever looked at the actual html? The classes are randomly generated lol, just using the structure would be too broad. Putting that dashboard icon is already a hack as it is.

@Torkin1
Copy link

Torkin1 commented May 18, 2021

I find that searching for the string "Update Google Chrome" is a bit fragile.

Using a string translated in system locale could solve the issue, at least in most cases

Btw i'm using the appimage, and I'm currently experiencing this issue too.

WALC

  • Installation type: AppImage
  • Version: 0.2.1
  • OS: Fedora release 33 (Thirty Three)

@Zzombiee2361
Copy link
Collaborator

That's like putting even more hack for a problem caused by another hack. We need a sturdy solution

@kotatsuman
Copy link

I'm experiencing this issue too, I wonder why it just started today for me, while someone is this 12 days ago.
I have WALC in Italian too.
I suppose I have to search and translate the "Update Google Chrome" string in some config file, but can you tell me please the path where that file is located?
Thanks

@mauromol
Copy link

Today I get this problem again. Tried to close/reopen WALC 3-4 times, but this time it seems not to fix the problem.

Still on 0.2.1, because I don't see new versions on snapcraft.

@mauromol
Copy link

Usually after some restart attempts, the issue gets fixed, but now it's from yesterday, after a Whatsapp update, that I can't use WALC anymore.

@Zzombiee2361 what about @cstayyab change suggested in #138 (comment)?

Meanwhile is there any workaround to make WALC work again? i.e.: clear out some settings folder or such?
Thanks in advance.

@kotatsuman
Copy link

kotatsuman commented Jul 21, 2021 via email

@mauromol
Copy link

It happened to me too and I solved launching WALC twice (whithout closing it). While the first window I launched was still showing the Chrome update message, the second one was showing WhatsApp Web QR code ready to scan.

Worked here in Ubuntu 20.04 as well, thank you for the tip! Though, the second instance of WALC had all the application settings reset to their default value... For instance, I was using the dark theme, but the second instance started with the default theme. I don't know how this is supposed to work... Fortunately this is not an application that requires too much customisation 😉

@kotatsuman
Copy link

kotatsuman commented Jul 23, 2021 via email

@mauromol
Copy link

Glad it worked for you too. I have no idea about settings, since mine don't reset. I installed WALC using Snap, did you compile sources maybe?

No I didn't, I'm also using snap.

@mauromol
Copy link

mauromol commented Aug 5, 2021

@kotatsuman today it happened again and I fixed it again by launching a second WALC instance. I confirm it's seen as a totally new instance, hence it must be paired with the Whatsapp mobile app again, it's seen as a new connected device and settings are yet again reset.

Looking forward for an actual fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants