Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: Fix remaining Python dependencies #31

Open
cstjean opened this issue Jun 29, 2017 · 2 comments
Open

TODO: Fix remaining Python dependencies #31

cstjean opened this issue Jun 29, 2017 · 2 comments

Comments

@cstjean
Copy link
Owner

cstjean commented Jun 29, 2017

train_test_split and all the code relying on importpy (as well as that function itself) ought to be reviewed and fixed to avoid loading scikit-learn unnecessarily.
@ValdarT
Copy link
Contributor

ValdarT commented Jan 19, 2019

Hey
Any chance you'll revisit this issue soon? In general, I think it would be a huge improvement if all the Python dependencies were optional - it's rather impractical to use this library in any inference code/service otherwise.

@cstjean
Copy link
Owner Author

cstjean commented Jan 19, 2019

Realistically, that seems unlikely in the near future, but PRs are very welcome.

@Thuener Thuener mentioned this issue Jul 29, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ValdarT @cstjean