Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
The parser sucks #4
The parser solves a fairly well-defined problem and has a simple and clean interface to the rest of LocustDB so this is quite easy to work on without knowing much about the rest of the code.
I hacked together the parser within a few hours during the original hack week, and it has mostly remained unchanged since. It has serious issues:
Even if we ultimately decide to build our own parser, it would probably not be a bad idea in the short term to just leverage some other existing SQL parser. All we would need to do is add an additional pass that rejects parts of SQL not supported by LocustDB (most of them) and maps the rest into the AST format expected by the query engine.
Awesome! This would be super high impact and bring LocustDB much closer to actually being usable.
Right now parsing is done by the
If there's anything I can help you with let me know.
Wow great find, this project seems really well aligned with what we want in LocustDB! I finally had some time to play around with the parser, all the functionality we need is there and it also looks like the AST it outputs is already very similar to LocustDB's AST.
Anyone wanna give it a shot?