Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in Spire via submodule? #1

Open
tangent-vector opened this issue Nov 14, 2016 · 1 comment
Open

Pull in Spire via submodule? #1

tangent-vector opened this issue Nov 14, 2016 · 1 comment

Comments

@tangent-vector
Copy link
Contributor

The codebase currently has Spire.h and Spire.cpp copy-pasted in somewhat deep in the source tree. Updating to a new version of the main Spire repository is not automated.

I expect that a lot of developers would want to see an example of a simple workflow using git submodule, where the entire Spire tree is pulled into a simple location like External/Spire or ThirdParty/Spire, and can be updated to a new version (or switched to a different branch) painlessly.

Such a change would also make it easier to work on the Spire implementation and the engine at the same time, by removing a manual copying step.

@csyonghe
Copy link
Owner

csyonghe commented Dec 6, 2016

The latest check-in is now using Spire as sub-directory (but not git submodule). Probably need to move to a upper directory for ease integration with submodules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants