Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Command Overhaul #4

Closed
ct-bess opened this issue Feb 4, 2021 · 0 comments
Closed

Event Command Overhaul #4

ct-bess opened this issue Feb 4, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request
Projects

Comments

@ct-bess
Copy link
Owner

ct-bess commented Feb 4, 2021

The way this command was initially implemented is really bad; Every minute Bean filters a map of events for ones that match the date & time. Rather than doing a search every minute and wasting precious resources, let's assemble the events in such a way that all Bean needs to do is look into an object's index using the date/time as the key, and if there's something in there at that index we proceed to do the normal event stuff.

Old way:

  • search all events for ones that match the current date/time

New way:

  • look into an object using the date/time as the key; truthy at that index implies we have an event there

ok have a nice day

@ct-bess ct-bess added the enhancement New feature or request label Feb 4, 2021
@ct-bess ct-bess self-assigned this Feb 4, 2021
@ct-bess ct-bess added this to To do in Febuary 2021 Feb 4, 2021
@ct-bess ct-bess moved this from To do to In progress in Febuary 2021 Feb 25, 2021
@ct-bess ct-bess removed this from In progress in Febuary 2021 Feb 27, 2021
@ct-bess ct-bess added this to To do in April 2021 Feb 27, 2021
@ct-bess ct-bess moved this from To do to In progress in April 2021 Feb 27, 2021
@ct-bess ct-bess moved this from In progress to Done in April 2021 Mar 1, 2021
@ct-bess ct-bess closed this as completed in 4ec7898 Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

1 participant