New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not transform the Geometry for each event (slow) #177

Closed

kosack opened this issue Mar 10, 2022 · 1 comment

Labels

Contributor

kosack commented Mar 10, 2022

The camera radii should be cached if used

protopipe/protopipe/pipeline/utils.py

Lines 670 to 674 in 1f392ea

    
           for tel in subarray.telescope_types: 
        
               cam_name = tel.camera.camera_name 
        
               geom = tel.camera.geometry 
        
               new_geom = geom.transform_to(frame) 
        
               camera_radii[cam_name] = new_geom.guess_radius()

kosack added the refactoring label

Contributor Author

kosack commented Mar 10, 2022

never mind, this is in init, so it happens only once

kosack closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment