Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventDisplay comparison notebook is included twice #33

Closed
maxnoe opened this issue Sep 16, 2020 · 4 comments · Fixed by #36
Closed

EventDisplay comparison notebook is included twice #33

maxnoe opened this issue Sep 16, 2020 · 4 comments · Fixed by #36

Comments

@maxnoe
Copy link
Member

maxnoe commented Sep 16, 2020

It is in docs/contributing (where it does not make sense I think) and the notebooks directory

@HealthyPear
Copy link
Member

usually I do this so the one in notebooks is an empty one to edit, while the one in the docs is a static copy with the latest results

@maxnoe
Copy link
Member Author

maxnoe commented Sep 16, 2020

That's not good! This just duplicates it and makes it hard to maintain. There are better ways to do this.

Like in ctapipe, where the notebooks are included empty in the repository and are executed during the docs build so the output is included in the docs.

@HealthyPear
Copy link
Member

I know, but since that is done by the CI pipeline there should be test data stored somewhere, which is not the case now, so that is why I didn't do it

@maxnoe
Copy link
Member Author

maxnoe commented Sep 25, 2020

Fixed in #36

@HealthyPear HealthyPear linked a pull request Sep 26, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants